search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

refactor: remove `arrayref` dep #67

Open Jamyw7g opened 1 year ago

Jamyw7g commented 1 year ago

Reduce third-party dependency.

mxinden commented 1 year ago

Can you expand on the rational here? While it might reduce compile times, I would much rather depend on a well established external crate with anything containing unsafe code.

Jamyw7g commented 1 year ago

In my opinion, there are two reasons, one is to reduce the use of macros, and the other is that the use of third-party crate require to audit. So I think we can implement some simple functions.