search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
86 stars 45 forks source link

fix: don't depend on unnecessary `multihash` features #77

Closed thomaseizinger closed 1 year ago

thomaseizinger commented 1 year ago

With these features activated, multihash is quite heavy. Whilst we are in the process of fixing this, removing these features is a first good step towards that.

I think technically, this is a breaking change unfortunately because we re-export all of multihash and thus someone could have relied on the presence of multihash::Code through the re-export of multihash.

mxinden commented 1 year ago

@thomaseizinger do you have some time to look at the "Build" CI failures? I am taking a look at the code coverage failures now.

thomaseizinger commented 1 year ago

@thomaseizinger do you have some time to look at the "Build" CI failures? I am taking a look at the code coverage failures now.

Maybe later tonight yes, otherwise likely only next week.

thomaseizinger commented 1 year ago

@vmx Can you change the repository settings as per https://matklad.github.io/2022/10/24/actions-permissions.html? The workflows don't run at the moment.

mxinden commented 1 year ago

@vmx Can you change the repository settings as per https://matklad.github.io/2022/10/24/actions-permissions.html? The workflows don't run at the moment.

Done