search

multiformats / rust-multiaddr

multiaddr implementation in rust
https://crates.io/crates/multiaddr
Other
88 stars 47 forks source link

feat!: mark `Protocol` as `non_exhaustive` #82

Closed thomaseizinger closed 1 year ago

thomaseizinger commented 1 year ago

As an effort towards #71, mark Protocol as non_exhaustive. This allows us to add new variants without breaking downstream code.

I think matching on the Protocol is important, thus I chose to use non_exhaustive here over making it opaque.

thomaseizinger commented 1 year ago

I am in favor of this change.

Is this a breaking change? If so, mind adding a changelog entry?

I did that locally and forgot to push 🤦‍♂️