search

multiformats / rust-multihash

multihash implementation in Rust
https://github.com/multiformats/multihash
Other
150 stars 60 forks source link

Copy slice instead of iterating in `wrap()` #203

Open mriise opened 2 years ago

mriise commented 2 years ago

digest.copy_from_slice(input_digest); instead of https://github.com/multiformats/rust-multihash/blob/c68638c9736284d0e52aacdcfc606e1d746db9ec/src/multihash.rs#L107-L111 This will stay open till https://github.com/rust-lang/rust/issues/57349

BigLep commented 1 year ago

@mriise : will you take this?

vmx commented 1 year ago

@BigLep: this issue will likely stay open until the linked Rust issue if fixed (can be years).

mriise commented 1 year ago

(though we dont actually use lables for this repo lol)