search

multiformats / rust-multihash

multihash implementation in Rust
https://github.com/multiformats/multihash
Other
150 stars 60 forks source link

Refactoring unwrap and handling errors #283

Closed kevin-valerio closed 1 year ago

kevin-valerio commented 1 year ago

Please, see https://github.com/multiformats/rust-multihash/issues/282 for more informations

mattheworris commented 1 year ago

It would be great to have a test with the malicious payload, to make sure we won't have a regression in the future.

I attempted to create a test, but I could not get the test to work properly in a no-std environment.

kevin-valerio commented 1 year ago

It would be great to have a test with the malicious payload, to make sure we won't have a regression in the future.

I attempted to create a test, but I could not get the test to work properly in a no-std environment.

See that link, I wrote a test there with the good Cargo.toml config to reproduce the bug.

mattheworris commented 1 year ago

It would be great to have a test with the malicious payload, to make sure we won't have a regression in the future.

I attempted to create a test, but I could not get the test to work properly in a no-std environment.

See that link, I wrote a test there with the good Cargo.toml config to reproduce the bug.

To clarify, I could not create a test that would work with cargo test in this repo. Regardless of what I tried (--no-default-features flags, etc.), std was always defined.

thomaseizinger commented 1 year ago

Replaced by https://github.com/multiformats/rust-multihash/pull/291.