fix: upgrade syn and synstructure (#362)

multiformats / rust-multihash

multihash implementation in Rust

https://github.com/multiformats/multihash

Other

150 stars 60 forks source link

fix: upgrade syn and synstructure (#362) #363

Closed jmg-duarte closed 3 months ago

jmg-duarte commented 3 months ago

fixes #362 closes #350 closes #301

I've added an Ident to utils::Attrs since attr.meta.to_token_stream() now includes it.
I've also removed ParseError since it didn't seem to be used (and tests seemed to passed)

jmg-duarte commented 3 months ago

@vmx stable (1.78) has different errors to 1.77, should I change the expected errors to match or should we change CI?

Personally, when I developed macros, I would pin them against the MSRV and test against it only

vmx commented 3 months ago

We currently only guarantee a MSRV for the main multihash crate with default features. We currently don't have one for the derive macro. One option is to add one (it would be 1.66.1). Though I think easiest for now would be to just update the test files to make them work with current stable Rust and be done.

vmx commented 3 months ago

The code coverage issue is unrelated. Feel free to ignore it and I'll make a PR for it later, or change the tarpaulin action version to 0.30.0, which should make it work.