search

multihack / multihack-brackets

Realtime collaboration for programmers. (Brackets Extension)
MIT License
24 stars 9 forks source link

Polish Diacritical issue #24

Closed Worie closed 7 years ago

Worie commented 7 years ago

Typing polish diacritical causes the peer who recieves it to lose connection with the one who sent it. The reciever can no longer get any updates from the peer who sent the diacritical letter (he can communicate with other peers, though)

I guess there's an overall encoding issue somewhere, Brackets DevTools shows: Uncaught SyntaxError: Unexpected string at index.html:1

I hadn't any ideas on the Issue name, please rename it to something that fits better when we know what is the real problem.

t-mullen commented 7 years ago

Can you post the diacritical that causes this, so I can reproduce?

Worie commented 7 years ago

It happened on ś in my case, haven't tested the rest: śćźżńłóąńę

tweakimp commented 7 years ago

Please also test special german letters ä,ö,ü and ß.

t-mullen commented 7 years ago

Ah, I know what this is. Diacriticals don't increase character length, which I was wrongly assuming was the same as byte length. This should be fixed in the next major version.

t-mullen commented 7 years ago

Yes, that was the issue.