search

multimeric / PandasSchema

A validation library for Pandas data frames using user-friendly schemas
https://multimeric.github.io/PandasSchema/
GNU General Public License v3.0
190 stars 35 forks source link

failing test and updated requirements for running tests #15

Closed caddac closed 6 years ago

caddac commented 6 years ago

Added a test that shows my error case, also updated the requirements.txt with the minimums I needed to run the tests using a venv.

caddac commented 6 years ago

@TMiguelT I've pushed what I think is a fix for this. Please let me know what you think.

multimeric commented 6 years ago

Hi, thanks for taking a look at this. I can see why this is an annoying bug, but you'll have to fix some things in your PR before I'll accept it

caddac commented 6 years ago

@TMiguelT I've updated all requested items. changing the requirements.txt as you requested (and removing/re-installing packages) worked for running tests via python setup.py test however to run tests via pycharm I had to manually install nose and pandas into my venv. No big deal but thought I'd mention it.

multimeric commented 6 years ago

Thanks. I'll have a look through your tests tomorrow, but just quickly it looks like your IDE reformatted the tests page. I was using a line length of 120, so they shouldn't have to wrap

caddac commented 6 years ago

sorry about that, I had 90 set for Apache-Airflow. Fixed it

caddac commented 6 years ago

@TMiguelT I've updated as requested

multimeric commented 6 years ago

Great! I'll merge this