search

multimeric / flapison

Flask extension to build REST APIs around JSONAPI 1.0 specification.
http://flask-rest-jsonapi.readthedocs.io
MIT License
13 stars 4 forks source link

Stability #1

Closed srhinos closed 5 years ago

srhinos commented 5 years ago

Hey, I love what flask-rest-jsonapi is trying to do but is just woefully under-maintained. Just wanted to reach out and check to see what environment you're using this in to see if we should use your branch or just make our own.

Thanks!

Edit: Really should have also included, insanely impressed by the code you've added on to this project and I'd be for sure contributing up-stream if thats something you're legit interested in as well!

multimeric commented 5 years ago

Hi @srhinos, yep I'm planning on maintaining my own fork. The master branch is currently up to date with all my PRs, and tests are passing. I'm just having issues with PyPy 3, which I'll likely disable and then I'll publish on PyPi. Feel free to submit and PRs you write here and I'm happy to review/merge them.

srhinos commented 5 years ago

Awesome! I know the maintainer killed global decorators for literally no reason and I’ve had it monkey patched in a production environment since so having it hosted on something like pypi where version control can be done would be insanely valuable for me!

On Nov 8, 2019, at 00:12, Michael Milton notifications@github.com wrote:

 Hi @srhinos, yep I'm planning on maintaining my own fork. The master branch is currently up to date with all my PRs, and tests are passing. I'm just having issues with PyPy 3, which I'll likely disable and then I'll publish on PyPi. Feel free to submit and PRs you write here and I'm happy to review/merge them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

multimeric commented 5 years ago

Were they decorators for routing? like @api.route(/some/url)? Because that's a feature I wanted as well. If you can point out the commit where they removed it I can probably just revert it and add some tests.

srhinos commented 5 years ago

Hey, yeah the commit was this https://github.com/miLibris/flask-rest-jsonapi/commit/0c212bd71e9f46ab633d93703bc29c1009222554

They didn't seem to replace it with anything else from what I could tell, the documentation hasn't been updated yet to reflect it if they did. I've been source diving this and other projects and it seems like theres some alternative in place, its just annoying.