search

multimeric / flapison

Flask extension to build REST APIs around JSONAPI 1.0 specification.
http://flask-rest-jsonapi.readthedocs.io
MIT License
13 stars 4 forks source link

Fix QueryStringManager use wrong schema #20

Closed pacoyang closed 4 years ago

pacoyang commented 4 years ago

Use self schema replace the schema get from get_schema_from_type in QueryStringManager property method fields. This change fix the bug when has multiple schema objects of the same type name.

multimeric commented 4 years ago

Hmm I don't quite understand your explanation of the problem. In any case, your change will break the query string parsing, as I explained in the code review.

Can you write a test that shows the issue, so we can ensure I understand what you mean, and also so we can't get a regression once it's fixed?

pacoyang commented 4 years ago

You are right 😂, I did not notice that issue. I will close this PR and write a new issue to describe my problem.