multimodallearning / pytorch-mask-rcnn

Other
2.02k stars 556 forks source link

bug in NMS #56

Open pfjaeger opened 6 years ago

pfjaeger commented 6 years ago

NMS is not working correctly, since the detections fed in are not sorted:

in nms/path_nms.py line 49:

nms.gpu_nms(keep, num_out, dets_temp, thresh)

the unordered 'dets_temp' are fed in instead of the ordered 'dets'. This is solvable by either changing line 43 to :

dets_temp = dets_temp[order].contiguous()

or just getting rid of the dets_temp and feeding in dets, since NMS should be rotation invariant.