Move layout by variable UI to the legend from context menu

multinet-app / multilink

A node-link visualization built to work with the multinet ecosystem.

https://multinet.app

Apache License 2.0

4 stars 2 forks source link

Move layout by variable UI to the legend from context menu #307

Closed JackWilb closed 2 years ago

JackWilb commented 2 years ago

Does this PR close any open issues?

Closes #286

Give a longer description of what this PR addresses and why it's needed

Moves the layout to the legend and uses the framework we have in place for dragging and dropping variables to assign them.

Provide pictures/videos of the behavior before and after these changes (optional)

New look:

Are there any additional TODOs before this PR is ready to go?

TODOs:

[x] When there are 2 axes assigned and we remove only 1, it should switch back to the one axis layout
[x] Check reactivity issues
[x] Add metadata (like degree) (tracking elsewhere)
[ ] #295
[x] #296

netlify[bot] commented 2 years ago

Deploy Preview for next-multilink ready!

Name	Link
Latest commit	5f21d5135018affcccef352ccc455b431fd0ee18
Latest deploy log	https://app.netlify.com/sites/next-multilink/deploys/6282c32575ffb00008b04752
Deploy Preview	https://deploy-preview-307--next-multilink.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

alexsb commented 2 years ago

Feedback: Awesome! Really cool.

Some thoughts:

Maybe we want a toggle or some way to explicitly switch to attribute driven layout? How is it implemented now, if an x and a y variable isn't defined, it uses forces?
Maybe we could use a better separation of layout/appearance variables and legend? Add a gray "Attributes" bar?