multinet-app / multilink

A node-link visualization built to work with the multinet ecosystem.
https://multinet.app
Apache License 2.0
4 stars 2 forks source link

Layout numerical variables with jitter, and allow categorical and numerical layouts concurrently #318

Closed JackWilb closed 2 years ago

JackWilb commented 2 years ago

Does this PR close any open issues?

No

Give a longer description of what this PR addresses and why it's needed

This fixes a bug I saw from #317. When laying out by a categorical and numerical variable, it would not jitter and animate. That's because the other axis was given a fixed value, so the simulation wouldn't update the node.

Fixing this issue also allowed me to fix the issue with jittering multiple nodes with the same value when laying out by 1 numerical variable. We fix in one axis and animate the other.

Provide pictures/videos of the behavior before and after these changes (optional)

One numerical variable: image

One numerical, one categorical: image

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 2 years ago

Deploy Preview for next-multilink ready!

Name Link
Latest commit 96473acac89494a75251a87fe4b2f0c682287ec9
Latest deploy log https://app.netlify.com/sites/next-multilink/deploys/62c7536d4d86050009dedc6d
Deploy Preview https://deploy-preview-318--next-multilink.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.