multinet-app / multilink

A node-link visualization built to work with the multinet ecosystem.
https://multinet.app
Apache License 2.0
4 stars 2 forks source link

Bump vue and typescript versions #320

Closed JackWilb closed 2 years ago

JackWilb commented 2 years ago

Does this PR close any open issues?

No

Give a longer description of what this PR addresses and why it's needed

This bumps the vue version to 2.7 and the typescript version to 4.7.

The vue change will allow us to port some of the code to use the new vue 3 <script setup>, which will help remove some of the boilerplate. It will also get us to a better place for when we're finally able to migrate to vue 3.

The typescript bump should help us by making it so we don't have to fight with the type system so much. I have some type changes planned, so this will help me as I'm working with that.

There was a tricky issue that I had to fix where the ref was named svg, which was conflicting the mounting of the SVG elements in the template (they would be replaced by comments). The fix was to rename the ref that pointed to the multimatrix SVG element

Provide pictures/videos of the behavior before and after these changes (optional)

N/A

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 2 years ago

Deploy Preview for next-multilink ready!

Name Link
Latest commit 2327a1de12f5970a5efaa33554ffdeb1f35dc967
Latest deploy log https://app.netlify.com/sites/next-multilink/deploys/62cf40e9a302780008d1e751
Deploy Preview https://deploy-preview-320--next-multilink.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.