multinet-app / multilink

A node-link visualization built to work with the multinet ecosystem.
https://multinet.app
Apache License 2.0
4 stars 2 forks source link

Migrate to use Pinia over Vuex #335

Closed JackWilb closed 1 year ago

JackWilb commented 1 year ago

Does this PR close any open issues?

Depends #334

Give a longer description of what this PR addresses and why it's needed

This vastly simplifies the store object that we have to maintain. We've gone from requiring mutations, to not, and we now have a path forward on the vue 3 sanctioned store library. While this change wasn't strictly necessary for that change, we're now not using direct-vuex, and we no longer need to use computed get/set logic to update. That is a huge simplification.

I made this an extension of #334 so that we can have these improvements on top of the vite changes.

The only remaining changes to get us fully up to date with vue 3 will be migrating to it, and using vuetify 3. Vuetify is still in beta, and not well documented at the moment. I think it would be prescient to wait a little while longer for that migration.

I removed some javascript Set logic here, since vue 2 doesn't deal with the reactivity of Sets. We can plan to add that back when we're using vue 3, since they are supported there.

Provide pictures/videos of the behavior before and after these changes (optional)

There should be no change

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 1 year ago

Deploy Preview for next-multilink ready!

Name Link
Latest commit 9f13ba7450611e5047903b8d885a2b3c36348da4
Latest deploy log https://app.netlify.com/sites/next-multilink/deploys/63a0cc69f6994e00086c2c9c
Deploy Preview https://deploy-preview-335--next-multilink.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.