multinet-app / multimatrix

A adjacency matrix visualization built to work with the multinet ecosystem.
https://multinet.app
Apache License 2.0
1 stars 0 forks source link

Fix sorting #393

Closed JackWilb closed 2 years ago

JackWilb commented 2 years ago

Does this PR close any open issues?

Depends on #391 Closes #259 Closes #260

Give a longer description of what this PR addresses and why it's needed

Fixes matrix sorting. You can now sort by node, cluster, etc.

Provide pictures/videos of the behavior before and after these changes (optional)

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 2 years ago

Deploy Preview for multimatrix ready!

Name Link
Latest commit 629edb284d3a0a4b75a49c994b643d5552d2b66f
Latest deploy log https://app.netlify.com/sites/multimatrix/deploys/62a0d8f7370e8e0008cc4d86
Deploy Preview https://deploy-preview-393--multimatrix.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

gotdairyya commented 2 years ago

Added pointer CSS to make it clear that the sorting icons act as buttons.

JackWilb commented 2 years ago

Looks and works well.

A couple of things I noticed, neither of which are critical:

* It's not intuitive what the sort should do in cases where there is aggregation

This is tracked in #294

* The sort treats all row labels as strings which gets funky with numbers

I'll fix this before merge