search

multinet-app / multimatrix

A adjacency matrix visualization built to work with the multinet ecosystem.
https://multinet.app
Apache License 2.0
1 stars 0 forks source link

Remove cycles from connectivity queries #410

Closed JackWilb closed 2 years ago

JackWilb commented 2 years ago

Does this PR close any open issues?

No Found here and potentially before: https://github.com/multinet-app/multimatrix/pull/409#pullrequestreview-1034719675

Give a longer description of what this PR addresses and why it's needed

Removes the cycles from the connectivity query. This should stop the start and end node being the same in multi hops. I have removed all 2 hop and 3 hop cycles. These are the only ones that can be present with our current number of hops (max = 3).

I also fixed an issue with the node/edge attribute selection in the query. Previously we would select n1.attribute, but for some variable names that causes problems. I've updated it so we select n1.`attribute`

Provide pictures/videos of the behavior before and after these changes (optional)

Changes are in the query so will change query results, but there are no UI changes.

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 2 years ago

Deploy Preview for multimatrix ready!

Name Link
Latest commit aa85fd85d15b452fcf3601fd9730da77addeaa22
Latest deploy log https://app.netlify.com/sites/multimatrix/deploys/62d9b01f2fa829000998cc93
Deploy Preview https://deploy-preview-410--multimatrix.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

gotdairyya commented 2 years ago

Test Query for 2 Hop: This is the go-to query for Graffinity. Works well with these recent changes to Multinet querying.

image
gotdairyya commented 2 years ago

Test Query for 2 Hop: This is the go-to query for Graffinity. Works well with these recent changes to Multinet querying.

In comparison, if the middle node is left to be an approximate match, I get the spinning wheel of doom

image
JackWilb commented 2 years ago

Should this be a toggle? There are potentially cases where we'd like the cycle to show. Maybe we even want just the start and end the same and no cycles in the middle?