multinet-app / multimatrix

A adjacency matrix visualization built to work with the multinet ecosystem.
https://multinet.app
Apache License 2.0
1 stars 0 forks source link

Allow setting cell size smaller and fix lineup infinite re-render bug and sort logic #476

Closed JackWilb closed 1 year ago

JackWilb commented 1 year ago

Does this PR close any open issues?

Closes #443 Closes #462

Give a longer description of what this PR addresses and why it's needed

This PR fixes a few bugs with lineup and adds the ability to make the matrix cells smaller.

For the matrix cells, I just had to increase the size of the range that I could use for the cells. There was also a bug where the lineup font size was not updating with the cell size correctly that I addressed.

In lineup, I changed the sort logic to allow lineup to sort the matrix and I'm currently working on opposite direction. There were also some bugs that led to the matrix re-rendering constantly that are addressed as a part of this fix. Somehow, the sort order was being changed which would trigger lineup to update the data and then re-render. Quite a mess.

Provide pictures/videos of the behavior before and after these changes (optional)

N/A

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 1 year ago

Deploy Preview for multimatrix ready!

Name Link
Latest commit 59e13547d969522025db2020a383f5f49c9e8e8e
Latest deploy log https://app.netlify.com/sites/multimatrix/deploys/64e95f6e9f23d00008a103f1
Deploy Preview https://deploy-preview-476--multimatrix.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.