multinet-app / multinet-client

Multinet web client application
https://multinet-app.readthedocs.io
4 stars 3 forks source link

Add user-specifiable csv delimiters and quote characters #262

Closed JackWilb closed 1 year ago

JackWilb commented 2 years ago

Does this PR close any open issues?

Closes #7

Give a longer description of what this PR addresses and why it's needed

This change adds a user-specifiable csv delimiter and quote character.

The csv analysis that already runs will suggest a delimiter, so I grabbed that as the default recommendation. When the user changes the delimiter and selects a different delimiter, the analysis is re-ran so that the preview is updated.

The quote character is a selection between a couple of options (" and '). Similarly, this re-runs the analysis so that the preview is updated accordingly.

Provide pictures/videos of the behavior before and after these changes (optional)

CSV2 before: image

CSV2 after: image

Upload UI changes: image

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 2 years ago

Deploy Preview for multinet-client ready!

Name Link
Latest commit cec10211fed118d59136c7cf7146da76e6b5088d
Latest deploy log https://app.netlify.com/sites/multinet-client/deploys/637e9a3cc5777d000898aee7
Deploy Preview https://deploy-preview-262--multinet-client.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.