multinet-app / multinet-client

Multinet web client application
https://multinet-app.readthedocs.io
4 stars 3 forks source link

No illegal object names for Arango #284

Closed JackWilb closed 1 year ago

JackWilb commented 1 year ago

Does this PR close any open issues?

No

Give a longer description of what this PR addresses and why it's needed

We currently allow illegal Arango names, which leads to network or table upload/creation errors. This is only told to the use after a failed upload. The Arango naming conventions are listed here.

To fix this, I added name validation and some error messages that show the user what is wrong before the creation/upload fails. This is much more robust than what we had previously.

Provide pictures/videos of the behavior before and after these changes (optional)

Screenshot 2023-03-28 at 3 29 26 PM

Are there any additional TODOs before this PR is ready to go?

No

netlify[bot] commented 1 year ago

Deploy Preview for multinet-client ready!

Name Link
Latest commit bba801f8cef220a3ff0801ca1d7e46d78e010cc9
Latest deploy log https://app.netlify.com/sites/multinet-client/deploys/64235c44ebad080008828b54
Deploy Preview https://deploy-preview-284--multinet-client.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.