search

multinet-app / multinet-server

Multinet server application
https://multinet-app.readthedocs.io
Apache License 2.0
4 stars 2 forks source link

Add missing check for "id" field #392

Closed jjnesbitt closed 2 years ago

jjnesbitt commented 4 years ago

Here

https://github.com/multinet-app/multinet-server/blob/2e1856cf132571d08f2a8c03e2f5f8188d22a0bc/multinet/uploaders/d3_json.py#L61

we don't check that "id" is in the row(s) first, so this results in a KeyError.

jjnesbitt commented 4 years ago

When fixing this we may want to also look at the other uploaders and make sure something similar isn't going on there as well

waxlamp commented 4 years ago

Did you run into this in the wild? Or did it come from a Sentry report?

jjnesbitt commented 4 years ago

It's from this sentry report