search

multipath-tcp / iproute-mptcp

IP-Route extensions for the out-of-tree MultiPath TCP kernel
http://multipath-tcp.org/pmwiki.php/Users/Tools
GNU General Public License v2.0
31 stars 19 forks source link

don't set multipath flags in IOCTL_COMPAT mode #1

Closed dtatulea closed 8 years ago

dtatulea commented 9 years ago

The flags type is short when using ioctl, but multipath flags are above that. To not confuse the user, show an error when IOCTL_COMPAT mode is used.

cpaasch commented 8 years ago

Hmm... Isn't it that we rather should do your change in ip_set() instead of doing it in iplink_parse()? Because, from ip_set we go directly to do_chflags() which does the ioctl call with the 16-bit ifr_flags field, while from iplink_parse, we do the setting via netlink, which supports 32 bits.

Or what am I missing?

dtatulea commented 8 years ago

You are right. I wanted to patch ip_set()...

cpaasch commented 8 years ago

This has been merged some time ago.