search

multipath-tcp / mptcp

⚠️⚠️⚠️ Deprecated 🚫 Out-of-tree Linux Kernel implementation of MultiPath TCP. 👉 Use https://github.com/multipath-tcp/mptcp_net-next repo instead ⚠️⚠️⚠️
https://github.com/multipath-tcp/mptcp_net-next
Other
888 stars 336 forks source link

[v0.94] mptcp: Fix compilation error when CONFIG_MPTCP is undefined #331

Closed lenormf closed 5 years ago

matttbe commented 5 years ago

Hi Frank,

Thank you for the patch!

I just included in mptcp_trunk + v0.94 and v0.93 with small modifications. https://github.com/multipath-tcp/mptcp/commit/0bb9c5d61fbe5a1edc68c94d14a6380b69468e29

Maybe next time, please send validated patches only for mptcp_trunk (except if it is specific to a previous version of course), add a signoff-by, mention what it fixes to ease the backports and verify it with checkcheck.pl. Ideally it is preferred to send patch to mptcp-dev ML for the visibility but that's another topic. We tried to summarise that on our wiki: http://multipath-tcp.org/pmwiki.php/Developer/SubmitAPatch But there are more details in the official kernel documentation because the workflow is the same ;-)

matttbe commented 5 years ago

Hi @cpaasch ,

I didn't include this patch in mptcp_v0.95 branch. Because mptcp_trunk has not been updated yet, I don't know if you prefer using git merge or git cherry-pick -xs :)

cpaasch commented 5 years ago

@matttbe Let's use cherry-picks from now on.

matttbe commented 5 years ago

@cpaasch good idea! Just cherry-picked the fix on mptcp_v0.95 then!