redundant call to tcp_tsq_write () in tcp_tsq_handler()

multipath-tcp / mptcp

⚠️⚠️⚠️ Deprecated 🚫 Out-of-tree Linux Kernel implementation of MultiPath TCP. 👉 Use https://github.com/multipath-tcp/mptcp_net-next repo instead ⚠️⚠️⚠️

https://github.com/multipath-tcp/mptcp_net-next

Other

888 stars 335 forks source link

redundant call to tcp_tsq_write () in tcp_tsq_handler() #386

Closed dejeneboru closed 4 years ago

dejeneboru commented 4 years ago

https://github.com/multipath-tcp/mptcp/blob/e0573b7437b00b96784a779dcad871772a677699/net/ipv4/tcp_output.c#L811 Is the call to tcp_tsq_write() in tcp_tsq_handler at the referenced point redundant or intended for some other purpose?

cpaasch commented 4 years ago

No, it is intended. The call to tcp_tsq_write with the meta-sk as an argument triggers the transmission on the meta-sk. What makes you think that it could be redundant?