search

multipath-tcp / mptcp

⚠️⚠️⚠️ Deprecated 🚫 Out-of-tree Linux Kernel implementation of MultiPath TCP. 👉 Use https://github.com/multipath-tcp/mptcp_net-next repo instead ⚠️⚠️⚠️
https://github.com/multipath-tcp/mptcp_net-next
Other
888 stars 335 forks source link

MP_PRIO from receiver for the Round Robin Scheduler #402

Open dhawaskar opened 3 years ago

dhawaskar commented 3 years ago

Hi,

I am testing MPTCP for my project, during which I came across this observation. I am using MP_PRIO signaling to disable the path from the receiver end. This disabling works with all the schedulers from sender side I tested. BLEST,ECF,Redunadant,minRTT but when sender side scheduler is set to Round Robin, even MP_PRIO signaling is sent, the path is not being disabled.

Does Round Robin Priority takes over MP_PRIO? If could you suggest me the way to make MP_PRIO with higher priority.

Thanks Sandesh

matttbe commented 3 years ago

Hi Sandesh,

Indeed, the Round Robin scheduler was implemented for tests only, mainly to prove it was possible to create other schedulers and round robin is not a good idea from a perf point of view. It doesn't support MP_PRIO.

rr_get_available_subflow() function in mptcp_rr.c should be adapted to support that. Do not hesitate to send a patch to support it if you need it.

Cheers, Matt