search

multipath-tcp / mptcp

⚠️⚠️⚠️ Deprecated 🚫 Out-of-tree Linux Kernel implementation of MultiPath TCP. 👉 Use https://github.com/multipath-tcp/mptcp_net-next repo instead ⚠️⚠️⚠️
https://github.com/multipath-tcp/mptcp_net-next
Other
889 stars 336 forks source link

Fix the redundant scheduler issue. #478

Closed ytxing closed 2 years ago

ytxing commented 2 years ago

Previously redsched_correct_skb_pointersset red_p->skb = NULL when red_p->skb_start_seq == meta_tp->snd_una. This issue causes the redundant scheduler keep sending reinjected packets. Replace !after with beforein line 192.

Closes: https://github.com/multipath-tcp/mptcp/issues/474 Fixes: 7835e7847026 ("mptcp: Fix use-after-free in the redundant scheduler") Signed-off-by: ytxing ytxing@mail.ustc.edu.cn

matttbe commented 2 years ago

Hi @ytxing

Thank you for the patch!

I slightly modified the commit message before integrate it to follow the kernel code style (checkpatch.pl and others), nothing important, the diff is still the same.

The new commit in mptcp_trunk: 5ffee1dcb2617a8a2f496addca614cb56e2e123f Backported to mptcp_v0.96 and mptcp0.95.