search

multipath-tcp / mptcp_net-next

Development version of the Upstream MultiPath TCP Linux kernel 🐧
https://mptcp.dev
Other
275 stars 39 forks source link

checkpatch: `Closes` tag is no longer accepted #373

Closed matttbe closed 1 year ago

matttbe commented 1 year ago

A new warning is produced when the Closes tag is used:

WARNING: Unknown link reference 'Closes:', use 'Link:' instead 
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373

If Reported-by is present before, we even have:

WARNING: Reported-by: should be immediately followed by Link: with a URL to the report
Reported-by: John Do <jj@dd.cc>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/373

Closes tags are really useful to help managing tickets and track them. We should ask for an exception.

matttbe commented 1 year ago

Patches have been applied in

https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches

Also visible there:

It looks like it is queued for the next version. Because it is not very clear, I suggest to keep this ticket open until the next merge window.

matttbe commented 1 year ago

Patches have now been applied in:

matttbe commented 1 year ago

Applied in Linus tree and in our tree: 44c31888098a ("checkpatch: allow Closes tags with links")