Closed matttbe closed 11 months ago
A suggestion from Eric Dumazet:
The fact that mptcp_is_tcpsk() was able to write over sock->ops was a bit strange to me. mptcp_is_tcpsk() should answer a question, with a read-only argument. I suggest changing the name of the helper to better reflect what it is doing.
The fact that mptcp_is_tcpsk() was able to write over sock->ops was a bit strange to me.
mptcp_is_tcpsk() should answer a question, with a read-only argument.
I suggest changing the name of the helper to better reflect what it is doing.
Source
mptcp_is_tcpsk() is currently used in one place but the name hides the fact sock->ops can be renamed.
mptcp_is_tcpsk()
sock->ops
A suggestion from Eric Dumazet:
Source
mptcp_is_tcpsk()is currently used in one place but the name hides the factsock->opscan be renamed.