Open matttbe opened 5 months ago
@pabeni : from what I understood, when you designed the in-kernel PM, you didn't want to create a list of received ADD_ADDR
, probably because it was enough to rely on the conn_list
.
Now that new(?) limits have been listed, do you think adding a new list would be OK?
Currently, upon the reception of an
ADD_ADDR
, new subflows are potentially created (depending on the limits), and acceptedADD_ADDR
are somehow stored in the 'conn_list'. If we want to browse the list of acceptedADD_ADDR
, the PM can iterate over the list of subflows, and compare addresses.There are some limits:
conn_list
, some events might no longer trigger the expected action, e.g. theadd_addr_accepted
counter will not be decremented upon the reception of anRM_ADDR
→ it might be needed to do a series of actions also when subflows are removed from theconn_list
.address
(Also note that in the
conn_list
, we could have more than one subflow using the same remote address, adding a bit more complexity.)Idea: storing received
ADD_ADDR
(in a list?) instead of relying on theconn_list
:RM_ADDR
is removed (fixing the issue with theadd_addr_accepted
counter), etc.pm_netlink
. Iterating over this list instead of theconn_list
.Linked to
mptcp: update add_addr_accepted and accept_add after subflow added
patch.