multipath-tcp / mptcp_net-next

Development version of the Upstream MultiPath TCP Linux kernel 🐧
https://mptcp.dev
Other
290 stars 41 forks source link

in-kernel PM: store received `ADD_ADDR` #496

Open matttbe opened 5 months ago

matttbe commented 5 months ago

Currently, upon the reception of an ADD_ADDR, new subflows are potentially created (depending on the limits), and accepted ADD_ADDR are somehow stored in the 'conn_list'. If we want to browse the list of accepted ADD_ADDR, the PM can iterate over the list of subflows, and compare addresses.

There are some limits:

(Also note that in the conn_list, we could have more than one subflow using the same remote address, adding a bit more complexity.)

Idea: storing received ADD_ADDR (in a list?) instead of relying on the conn_list:

Linked to mptcp: update add_addr_accepted and accept_add after subflow added patch.

matttbe commented 5 months ago

@pabeni : from what I understood, when you designed the in-kernel PM, you didn't want to create a list of received ADD_ADDR, probably because it was enough to rely on the conn_list.

Now that new(?) limits have been listed, do you think adding a new list would be OK?