coveralls
commented
2 years ago Pull Request Test Coverage Report for Build 2626380835
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.03%) to 62.342%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/configuration.c | 0 | 1 | 0.0% | ||
| <!-- | Total: | 0 | 1 | 0.0% | --> |
| Totals | |
|---|---|
| Change from base Build 2625646526: | -0.03% |
| Covered Lines: | 1187 |
| Relevant Lines: | 1904 |
The section of merge_config() that copies entries from one plugins_to_load queue to another was copying string pointers from one to the other. When the source queue was freed, the string pointers in the destination queue became invalid.
This manifested as garbage strings for the plugins_to_load value if the load-plugins line was used in mptcpd.conf
To fix, populate the destination queue entries with l_strdup()'d strings.