on import "<command-line>: warning: ISO C++11 requires whitespace after the macro name"

multiphenics / multiphenicsx

multiphenicsx - easy prototyping of multiphysics problems in FEniCSx

https://multiphenics.github.io/

GNU Lesser General Public License v3.0

40 stars 7 forks source link

on import "<command-line>: warning: ISO C++11 requires whitespace after the macro name" #1

Closed MagunRa closed 3 years ago

MagunRa commented 3 years ago

Hi,

when import multiphenicsx I get the warning <command-line>: warning: ISO C++11 requires whitespace after the macro name. It seems not to stop the import, but it is really irritating.

Best Regards, Moritz

francesco-ballarin commented 3 years ago

Hi Moritz,

does it happen every time (across different runs) you import multiphenicsx, or only the first time?
can you share some info on your system (e.g., compiler version)?

Thanks, Francesco

MagunRa commented 3 years ago

Hi Francesco, I am using the jupyter notebook from the docker image (on a windows host, if this matters). It happens only the first time I import multiphenicsx.

Rest regards, Moritz

francesco-ballarin commented 3 years ago

Hi @MagunRa , can you check if https://github.com/multiphenics/multiphenicsx/commit/ed18432ebba9f65a28e886ff6e42c85d89d8614a fixes the issue for you?

Edit: our CI updates the docker image only when pushing/merging to main. To get that commit into the current docker image you may add a cell with e.g.

!cd /usr/local/lib/python3.9/dist-packages/multiphenicsx-0.1.dev1-py3.9.egg && wget https://github.com/multiphenics/multiphenicsx/commit/ed18432ebba9f65a28e886ff6e42c85d89d8614a.diff -O diff && patch -p1 < diff

MagunRa commented 3 years ago

Yes it does resolve the warning. Best Regards

francesco-ballarin commented 3 years ago

Closed via https://github.com/multiphenics/multiphenicsx/commit/ed18432ebba9f65a28e886ff6e42c85d89d8614a