multiplegeorges / vue-cli-plugin-s3-deploy

A vue-cli plugin that uploads your built Vue.js project to an S3 bucket
MIT License
331 stars 51 forks source link

Deploy path fails in 4.0.0-rc3 #104

Closed itsdrew closed 4 years ago

itsdrew commented 4 years ago

pluginOptions: { s3Deploy: { ... deployPath: '/path', ... } }

In V 3.0.0 if I set the deploy path to /path, files get deployed to the bucket as expected: bucket/path

In V4.0.0-rc3: if I set the deploy path to '/path', files get deployed to the bucket as: bucket//path//path if I set the deploy path to 'path', files get deployed to the bucket as: bucket/path/path

Edit: Just saw your comment on the most recent commit. Looks like you are aware of the duplicating issue. Should the deploy path start with a "/", or should we leave the leading "/" out?

nicekiwi commented 4 years ago

I'll have to test this.

nicekiwi commented 4 years ago

Yikes, this is annoying! Defo will fix. The leading / is supposed be the default and should be required when adding an extra path /some/kinda/path.

bu-ra3y commented 4 years ago

Fixing this would help me too.

euan-forrester commented 4 years ago

Also if you put the slash after, like 'path/', then your stuff gets uploaded with 'undefinedundefined' prepended to every file

bu-ra3y commented 4 years ago

This is alluded to in the first post, but specifically, another example of this going wrong is:

If you set the deployPath to:

a/b

It will be deployed to: a/b/a/b/

tarasbilohan commented 4 years ago

My pull requests should resolve these problems

109 #110

nicekiwi commented 4 years ago

RC4 has been released in @next which fixes this. 🌮