search

multiplegeorges / vue-cli-plugin-s3-deploy

A vue-cli plugin that uploads your built Vue.js project to an S3 bucket
MIT License
331 stars 51 forks source link

Fix bug with dual deploy path #110

Closed tarasbilohan closed 4 years ago

tarasbilohan commented 4 years ago

Config example

module.exports = {
  pluginOptions: {
    s3Deploy: {
      ...
      deployPath: '/some-path/',
      ...
    }
  }
}

All files uploaded to path /some-path/some-path/...

omanizer commented 4 years ago

I've confirmed this PR fixes the issue. Any idea when this gets merged?

demiro commented 4 years ago

PLEASE, pretty please, merge this... is a huge issue!

nicekiwi commented 4 years ago

This does not solve the issue, it just disables the deployPath feature.

nicekiwi commented 4 years ago

@demiro has this issue been resolved the issue for you in the rc4 release?

tarasbilohan commented 4 years ago

@nicekiwi version 4.0.0-rc4 works for me. Changes from commit https://github.com/multiplegeorges/vue-cli-plugin-s3-deploy/commit/cf0746f356b9d1dfac7413bafdc8ca53f7624ab1#diff-5faf43f81de05c8fa81c690320ee8f4a have fixed the issue. This pull request is not actual.

demiro commented 4 years ago

@demiro has this issue been resolved the issue for you in the rc4 release?

yes it is... it is working now. thanks for fixing so quick