search

multiplegeorges / vue-cli-plugin-s3-deploy

A vue-cli plugin that uploads your built Vue.js project to an S3 bucket
MIT License
331 stars 51 forks source link

Typo when overriding endpoint? #121

Open euan-forrester opened 4 years ago

euan-forrester commented 4 years ago

I noticed this line:

https://github.com/multiplegeorges/vue-cli-plugin-s3-deploy/blob/master/src/deployer.js#L24

Should it instead be config.options.endpoint? There's no mention of overrideEndpoint anywhere in the readme

nicekiwi commented 4 years ago

Hmm not sure about this one, as there are un-documented features floating around in the @next branch. endpoint would make sense. But I'm ignoring the current releases as much as possible as the project structure changes quite a bit between current and now rc5.

euan-forrester commented 4 years ago

Fair enough :). Doesn't seem to have tripped anyone up yet. Looking forward to seeing what's coming up!