multiplegeorges / vue-cli-plugin-s3-deploy

A vue-cli plugin that uploads your built Vue.js project to an S3 bucket
MIT License
331 stars 50 forks source link

ERROR ReferenceError: stopSpinner is not defined #52

Open jkwasniak opened 5 years ago

jkwasniak commented 5 years ago

When using the plugin I get (i use CloudFront -> VUE_APP_S3D_ENABLE_CLOUDFRONT=true) the following error message:

✔ All 89 assets have been successfully deployed to https://s3-eu-central-1.amazonaws.com/www.xxxxxxx.de/
⠋ Invalidating CloudFront distribution: YYYYYYYYYYYY INFO  Deployment complete.
✔ Invalidating CloudFront distribution: YYYYYYYYYYYY
 INFO  Invalidation ID: IXXYYXXYYXXYYXX
 INFO  Status: InProgress
 INFO  Call Reference: vue-cli-plugin-s3-deploy-1545478460895
 INFO  See your AWS console for on-going status on this invalidation.
 ERROR  ReferenceError: stopSpinner is not defined
ReferenceError: stopSpinner is not defined
    at invalidateDistribution (....../node_modules/vue-cli-plugin-s3-deploy/s3deploy.js:180:5)
    at process.internalTickCallback (internal/process/next_tick.js:77:7)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

i use :

"vue": "^2.5.21",
"@vue/cli-service": "^3.2.0",
"vue-cli-plugin-s3-deploy": "git://github.com/multiplegeorges/vue-cli-plugin-s3-deploy.git#master"
"vue-template-compiler": "^2.5.21"
nicekiwi commented 5 years ago

Hmmm this is awkward..

frankisans commented 5 years ago

Just change to spinner.stop()

    error(`AWS Request ID: ${err.requestId}`)
    throw err
  } finally {
    spinner.stop()
  }
}