search

multiprocessio / datastation

App to easily query, script, and visualize data from every database, file, and API.
https://datastation.multiprocess.io
Other
2.9k stars 112 forks source link

add xlsm extension to mime detector #252

Closed tooolbox closed 2 years ago

tooolbox commented 2 years ago

Tried to run dsq on an Excel workbook with macros enabled, got a "unknown mimetype for file" error, which I traced back to this.

eatonphil commented 2 years ago

OK! But the macros won't be evaluated.

tooolbox commented 2 years ago

For sure, but just having macros in the workbook doesn't mean they are vital to calculating the data.

Not totally sure why that test failed btw, seems like a frontend issue.

eatonphil commented 2 years ago

It's ok, those are integration tests that fail when developers outside the project run tests because they make use of github secrets (to test against public apis with auth).

eatonphil commented 2 years ago

Now if you want to, make a PR in dsq that updates the go.mod to point to the commit I just merged. (That way you get credit there too).

If you don't feel like doing that then I'll do it.