search

multiprocessio / datastation

App to easily query, script, and visualize data from every database, file, and API.
https://datastation.multiprocess.io
Other
2.9k stars 112 forks source link

Fix the data error when loading json with path #298

Closed xwjdsh closed 2 years ago

xwjdsh commented 2 years ago

Fix https://github.com/multiprocessio/dsq/issues/91, https://github.com/multiprocessio/dsq/issues/96

eatonphil commented 2 years ago

Awesome! I was dreading dealing with this. This seems like a good fix for now.

xwjdsh commented 2 years ago

@eatonphil I'd like to add some test cases, should I update this PR or open a new PR in dsq repo?

eatonphil commented 2 years ago

Tests in both would be great. Tests here help show the issue earlier. We can just add a basic one to dsq when you update the go.mod there after this is merged.

xwjdsh commented 2 years ago

Sorry for being late, I added a test case, and after this is merged, I will add a test case of the excel file to dsq.

eatonphil commented 2 years ago

No problem! Take your time!

xwjdsh commented 2 years ago

Oh, the CI failed. It looks like a config issue, I have no idea how to fix it.

"Unable to retrieve Sheets client: unexpected end of JSON input"
eatonphil commented 2 years ago

Those tests fail unless it's run by someone in the Github multiprocessio org. They are expected for most contributors to fail.

Thanks for the fix!