Closed maarten-ic closed 1 year ago
Hmm, shouldn't ymmsl.Configuration.check_consistent()
catch this? Is it not getting called somehow?
Looks like it's only called when using libmuscle.runner.run_simulation
, not when using muscle_manager --start-all
:
$ git grep 'check_consistent'
libmuscle/python/libmuscle/runner.py:284: configuration.model.check_consistent()
$
So, then this issue may reduce to "Make sure check_consistent
is called when starting the manager" (perhaps only when doing --start-all
).
Reproduction scenario:
docs/source/examples/rd_python.ymmsl
, change macro/implementation todiffusion_pythonX
(or something else for which no entry exists in the implementations)make test_examples
)Expected behaviour
A clear error message that the configuration is not correct (e.g. "Implementation 'diffusion_pythonX' of component 'macro' is not defined in the yMMSL configuration.")