multiscale / muscle3

The third major version of the MUltiScale Coupling Library and Environment
Apache License 2.0
25 stars 13 forks source link

Check consistency of execution_model and resources #168

Closed LourensVeen closed 1 year ago

LourensVeen commented 1 year ago

If you specify openmpi or intelmpi for the execution_model but also specify threads rather than mpi_processes, you should get an error, but you don't.

maarten-ic commented 1 year ago

Looks like this is already checked by libymmsl in Configuration.check_consistency: https://github.com/multiscale/ymmsl-python/blob/develop/ymmsl/configuration.py#L299

Therefore, fixing #161 should also fix this issue