search

multiscale / muscle3

The third major version of the MUltiScale Coupling Library and Environment
Apache License 2.0
25 stars 13 forks source link

Update integration test #215

Closed maarten-ic closed 1 year ago

maarten-ic commented 1 year ago

This test works by taking snapshots based on wallclock_time. This is less reliable and failed every now and then in CI.

Updated the test, hopefully it doesn't fail anymore in CI after this.

LourensVeen commented 1 year ago

I don't get it. Is this just about statistics, a shorter run leaves fewer opportunities for something to go wrong?

maarten-ic commented 1 year ago

Previously the components were supposed to run for 2.0 seconds, and take a snapshot every 0.5 second AND take a snapshot at the end. This was supposed to lead to 5 snapshots (at 0.5, 1.0, 1.5 and 2.0 seconds and the final one), which it always did on my laptop.

However, on CI, it sometimes made only 4 snapshots. My hunch is that the 2.0 second one was not always taken (or being the same as the final one) in CI, so now I've let it run for only 1.8 seconds so the 2.0 second snapshot should never be taken. Hopefully that fixes the random CI failures 🤞