search

multiscale / muscle3

The third major version of the MUltiScale Coupling Library and Environment
Apache License 2.0
25 stars 13 forks source link

Handle instances that quit with 0 before registering #223

Closed LourensVeen closed 1 year ago

LourensVeen commented 1 year ago

This addresses #163 by making the InstanceManager check with the InstanceRegistry that an instance which quit with exit code 0 did register before doing so. If it didn't, that's an error and handled accordingly by shutting down the rest of the simulation and logging an error.

This needs #222 to be merged first.

LourensVeen commented 1 year ago

I'm using "addresses" intentionally :smile:. I don't like closing an issue reported by a user before the fix for it is actually in the user's hands. Just merging it into develop doesn't actually fix their issue after all.

So I have a "Ready for release" label that I apply after it's merged, and the issue isn't closed until a new version has been released with the fix in it, preferably by the original submitter of the issue after confirming that it works for them now.