multiscale / muscle3

The third major version of the MUltiScale Coupling Library and Environment
Apache License 2.0
25 stars 13 forks source link

Protobuf 3.0.0 in Python causes a gRPC error #48

Closed LourensVeen closed 4 years ago

LourensVeen commented 4 years ago

If you have protobuf 3.0.0 installed and then install muscle3, it seems like it doesn't upgrade protobuf to a version that will work with grpc 1.17.1. Need to check the dependencies here; shouldn't installing grpc automatically bump protobuf to a version new enough to work with it?

LourensVeen commented 4 years ago

Seems like grpc setup.py doesn't even list protobuf as a dependency. So you need to depend your package on both, and make sure that the versions work together. We're doing at least grpc 1.24.3 and protobuf 3.10.0 now, those were released around the same time so should work together.