multisig-labs / multi-party-sig

Implementation of protocols for threshold signatures
Apache License 2.0
4 stars 2 forks source link

Collisions in hash function used for commitments #11

Closed 0xJohnnyGault closed 2 years ago

0xJohnnyGault commented 2 years ago

Audit: KS-SBCF-F-05

Location: protocols/cmp/keygen/round3.go:154

Description

The hash function WriteAny does not build domain separation properly and collisions can be easily built. It can allow to make an honest participant look like a culprit during the key generation.

Recommendation

Use a hash function with proper domain separation and add the previous test in the test set.