search

multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.41k stars 438 forks source link

Hash function return string is not in lowercase anymore #1526

Closed botder closed 4 years ago

botder commented 4 years ago

Describe the bug Before the changes to the Lua argument parser, hash used to return a lowercase hexadecimal string.

Old code https://github.com/multitheftauto/mtasa-blue/blob/a4f447ae8047b6d2d65077f093adff69b16b3246/Shared/mods/deathmatch/logic/luadefs/CLuaCryptDefs.cpp#L90-L95

New code https://github.com/multitheftauto/mtasa-blue/blob/629f96bedf261c8ba1da5d165d141988555d0034/Shared/mods/deathmatch/logic/luadefs/CLuaCryptDefs.cpp#L50-L53 https://github.com/multitheftauto/mtasa-blue/blob/629f96bedf261c8ba1da5d165d141988555d0034/Shared/sdk/SharedUtil.Hash.hpp#L593-L598 https://github.com/multitheftauto/mtasa-blue/blob/629f96bedf261c8ba1da5d165d141988555d0034/Shared/sdk/SharedUtil.Hash.hpp#L519-L531

Expected behaviour Output must be in lowercase.

qaisjp commented 4 years ago 
-      return GenerateHashHexString(hashFunction, strSourceData);
+      return GenerateHashHexString(hashFunction, strSourceData).ToLower();

Just this?

botder commented 4 years ago

LGTM