search

multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.39k stars 429 forks source link

ug_spoiler and ug_nitro crash #1979

Open MrSol0 opened 3 years ago

MrSol0 commented 3 years ago

Describe the bug This bug concerns the hierarchy of custom models in MTA which makes the game crash for all clients if you upgrade a vehicles ug_spoiler or ug_nitro.

To reproduce First of all check the vehicle Model's hierarchy, i'm using model 421 in this example, 1- Change the model's hierarchy by putting ug_spoiler or ug_nitro in top of chassis_dummy [2] 2- Load the model and try upgrade the spoiler, this will lead you to crash and after you restart you will get [1]. 3- Change the model's hierarchy by putting ug_spoiler and ug_nitro uner chassis_dummy [3] 4- The model will load fine and cause no problem.

Expected behaviour This is inot the first model i see that has ug_spoiler or ug_nitro in top of chassis_dummy in GTA, so models with this are very common but work fine for SAMP or GTA, but can cause a crash in MTA [1]. and expected to work fine without crashing.

Screenshots 1- https://i.imgur.com/tobWO9t.png 2- https://i.imgur.com/WbzXkqn.png 3- https://i.imgur.com/RFyq4Co.png 4- https://i.imgur.com/SMA1cJC.png

Version Multi Theft Auto v1.5.8-release-20779

Additional context After checking getVehicleComponents and getVehicleComponentPosition it seems like they working just fine as you can see in [4], i first thought that MTA wasn't seeing the components, however it can clearly read them and get their position, my first report was from previous experience but MTA seems to have fixed the issue.

Download This link is for both the good DFF file and the one with the issue. https://www.upload.ee/files/12721918/ug_spoiler_ug_nitro.rar.html

Dutchman101 commented 3 years ago

Please provide some examples of crash dialog info.. or at the very least, offset.

cause mta crashes for all clients inside a server as a side effect

I've never heard of that, so i doubt it.

Do you have reproduction resource, or a DFF with the described dummies situation?

Please also make proper reproduction steps and resource for the getVehicleComponents issue of not listing all components. Eventually it would be nice if you can just improve the main post for this issue with the desired details & reproductions, or even split the function and crash issue into 2 separate issues.

MrSol0 commented 3 years ago

Please provide some examples of crash dialog info.. or at the very least, offset.

cause mta crashes for all clients inside a server as a side effect

I've never heard of that, so i doubt it.

Do you have reproduction resource, or a DFF with the described dummies situation?

Please also make proper reproduction steps and resource for the getVehicleComponents issue of not listing all components. Eventually it would be nice if you can just improve the main post for this issue with the desired details & reproductions, or even split the function and crash issue into 2 separate issues.

It was my fault, i have revised my report and included that my original report was wrong as getVehicleComponents was working fine. i hope the current report is clear enough, thanks.