multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.37k stars 423 forks source link

Corona reflections do not render on all roads #2750

Open lopezloo opened 1 year ago

lopezloo commented 1 year ago

Describe the bug

Some road models do not have is_road model flag set so these do not reflect corona reflections. This is single player issue.

Steps to reproduce

crun setCoronaReflectionsEnabled(2) me.position = Vector3(2046, 1549, 10) marker = Marker(me.position, "corona", 1.0) marker:setCoronaReflectionEnabled(true)

Describe the solution you'd like

We could set is_road flag for such models.

Additional context

  1. Depends on #1714.
  2. There was single player mod fixing that but I can't find it now.

Example positions: large part of Las Venturas.

Security Policy

FileEX commented 1 year ago

There was single player mod fixing that but I can't find it now.

Probably you mean this mod: https://www.gtainside.com/en/sanandreas/mods/70869-road-reflections-fix-1-0/

lopezloo commented 1 year ago

There was single player mod fixing that but I can't find it now.

Probably you mean this mod: https://www.gtainside.com/en/sanandreas/mods/70869-road-reflections-fix-1-0/

No, the issue this mod fixes was already fixed in MTA. There is mod which changes the is_road flag for models which have them not set.