multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.41k stars 435 forks source link

Crash when trying to "add" collision for ID from engineRequestModel #3342

Open FileEX opened 7 months ago

FileEX commented 7 months ago

Describe the bug

When adding a collision for ID with engineRequestModel, a crash occurs for the timed-object type. I know that this type has no collisions, but it shouldn't result in a crash.

image

Crash offset: `0x1E26EE`` (ProcessEntityCollision).

Steps to reproduce

local id = engineRequestModel("timed-object")

local col = engineLoadCOL("test.col")
engineReplaceCOL(col, id)

local txd = engineLoadTXD("test.txd")
engineImportTXD(txd, id)

local dff = engineLoadDFF("test.dff")
engineReplaceModel(dff, id, true)

Version

Multi Theft Auto v1.6-release-22396

Additional context

No response

Relevant log output

No response

Security Policy

ffsPLASMA commented 5 months ago

I confirm crashing for me as well with same offset when starting to use timed-objects on new IDs.

TheNormalnij commented 5 months ago

Do you have a test resource? I tested on latest commit and there is no crash.

Proxy-99 commented 3 months ago

@FileEX

FileEX commented 3 months ago

For me the crash no longer occurs. Tested on build 22518

FileEX commented 3 months ago

@TheNormalnij Crash still occurs though

image

Test resource: colcrash.zip

Crash does not always occur immediately. Sometimes you need to reconnect, sometimes there is a crash immediately after starting the resource