multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.3k stars 412 forks source link

Ped sync improvements #3480

Closed tederis closed 1 week ago

tederis commented 1 week ago

This PR is a reimplementation of #800 with additional fixes in rotation interpolation.

The video below demonstrates that even without animations a ped is well synchronized (in comparison to the pre-PR). https://youtu.be/17vEh7k_RSI?si=8kxGwODs7lIn8OaF

Note that since peds are correctly syncronized now, there may be problems with old scripts relying on a ped's animation speed. These scripts will have to use animation without a root motion or use setPedAnalogControlState.

Fernando-A-Rocha commented 1 week ago

Do you have a video of how it looks without this PR? 😁

tederis commented 1 week ago

Do you have a video of how it looks without this PR? 😁

There's the old video (from the previous PR) with the pre-PR behaviour: https://youtu.be/UcSOXd9PxhE?si=cbNeF8FVg-xf5tBa

Fernando-A-Rocha commented 1 week ago

Nice, good job. The difference is notable.

TheNormalnij commented 1 week ago

lgtm