multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.42k stars 438 forks source link

isElementInWater add support for objects elements #3740

Open Proxy-99 opened 2 months ago

Proxy-99 commented 2 months ago

Is your feature request related to a problem? Please describe.

isElementInWater does not support objects

Describe the solution you'd like

it should work as vehicles api since objects has a Bounding Box to similar logic could be followed

Describe alternatives you've considered

No response

Additional context

No response

Security Policy

CrosRoad95 commented 2 months ago

Woudln't be smart from api point of view to provide functions to check if given point or volume is inside water and function to get all water volumes? because that is probably enough to implement all sort of water related function

And then deprecate isElementInWater, move it implementation to lua ( simillar to "inspect" function )

Fernando-A-Rocha commented 2 months ago

Woudln't be smart from api point of view to provide functions to check if given point or volume is inside water and function to get all water volumes? because that is probably enough to implement all sort of water related function

And then deprecate isElementInWater, move it implementation to lua ( simillar to "inspect" function )

That would indeed be very smart and modern. +1