search

multitheftauto / mtasa-blue

Multi Theft Auto is a game engine that incorporates an extendable network play element into a proprietary commercial single-player game.
https://multitheftauto.com
GNU General Public License v3.0
1.37k stars 423 forks source link

Crash: attaching a truck-trailer to a towtruck #445

Closed ArranTuna closed 4 years ago

ArranTuna commented 5 years ago

Describe the bug when using attachTrailerToVehicle to attach a truck-trailer to a towtruck GTA crashes

To Reproduce attaching a trailer to a towtruck via attachTrailerToVehicle

Expected behavior no crash

Screenshots If applicable, add screenshots to help explain your problem.

MTA Client (please complete the following information): 1.5.5

MTA Server (please complete the following information): n/a

Additional context https://bugs.mtasa.com/view.php?id=8668

Dutchman101 commented 5 years ago

I just want to reference this fix in another branch: https://github.com/patrikjuvonen/mtasa-blue/commit/3d1cf454d2a58e24504d4fe9c33396693655497e

Is there any reason for it not to be ready yet, @patrikjuvonen?

patrikjuvonen commented 5 years ago

I just want to reference this fix in another branch: patrikjuvonen@3d1cf45

Is there any reason for it not to be ready yet, @patrikjuvonen?

My fix is only partial as it fixes the crash but not what happens afterwards which is basically that the camera gets stuck somewhere on the map. Will need further work but haven't had the time to investigate entirely. Also my fix only takes into account towtrucks. Technically you can tow using any vehicle.

Dutchman101 commented 5 years ago

I just want to reference this fix in another branch: patrikjuvonen@3d1cf45 Is there any reason for it not to be ready yet, @patrikjuvonen?

My fix is only partial as it fixes the crash but not what happens afterwards which is basically that the camera gets stuck somewhere on the map. Will need further work but haven't had the time to investigate entirely. Also my fix only takes into account towtrucks. Technically you can tow using any vehicle.

Ah, that's fine, i just asked the question for issue documentation.

Further documentation: 1) There has been another (test)fix applied for this crash in the past: https://github.com/multitheftauto/mtasa-blue/commit/370e358b2c0b202de890e480fedf76a83ab3dbc3

^ Might shed a light on what's going on, @patrikjuvonen The crash continues to exist on same offset (gta_sa @ 002ac57c) after said fix. It may be a split cause (that only one of the causes leading to it has been fixed), but you could talk to @sbx320 for details about his investigation.

This crash is around #15th most popular SA crash. Servers that are affected should modify their scripts to stop doing things that trigger the issue; refer to bug description above.